Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation notes: Changes needed if we have products for natural persons #372

Open
yolile opened this issue Aug 19, 2024 · 1 comment
Labels
topic: documentation Improvements or additions to documentation

Comments

@yolile
Copy link
Member

yolile commented Aug 19, 2024

When we have credit products for natural persons we will need to:

  • Remove the filters for not inviting natural persons at all
  • Restore the filter for showing credit products depending on the borrower's type (see 366 exclude legal person #371)
@jpmckinney
Copy link
Member

When restoring the filter 8d0ef0a we should make BorrowerBase use an enum for type. The code in that commit instead compared to a string from the CCE API, which is potentially unstable (and it means Colombia logic bleeds into the model – which it does elsewhere like "COP" defaults, but we try to limit it).

@jpmckinney jpmckinney added the topic: documentation Improvements or additions to documentation label Aug 20, 2024
@jpmckinney jpmckinney changed the title Changes needed if we have products for natural persons Implementation notes: Changes needed if we have products for natural persons Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants