Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

366 exclude legal person #371

Merged
merged 2 commits into from
Aug 19, 2024
Merged

366 exclude legal person #371

merged 2 commits into from
Aug 19, 2024

Conversation

yolile
Copy link
Member

@yolile yolile commented Aug 19, 2024

closes #366

@yolile yolile requested a review from jpmckinney August 19, 2024 19:00
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what the deleted code was trying to do (original 8c58d7a)

@yolile
Copy link
Member Author

yolile commented Aug 19, 2024

I don't understand what the deleted code was trying to do (original 8c58d7a)

So, we have a feature to filter credit products by borrower type (e.g. some products are available for legal persons only and others for both or only natural persons). But currently, all our credit products are for legal persons only, so we are not sending invitations to natural persons at all (because otherwise they were accessing Credere but then not seeing any products at all, so until we have products for natural persons we don't need this filter). I will create an issue.

@jpmckinney
Copy link
Member

Is the deleted code a problem? Will it not be relevant if we add products for natural persons?

@jpmckinney
Copy link
Member

jpmckinney commented Aug 19, 2024

Ah, well the code hardcodes SUPPLIER_TYPE_TO_EXCLUDE (which is why the logic seemed unusual to me), so might as well delete it and restore it with something better #372.

@yolile yolile merged commit 6adc3c2 into main Aug 19, 2024
9 checks passed
@yolile yolile deleted the 366-exclude-legal-person branch August 19, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More legal person exclusion rules
2 participants