-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix translation of application status. feat: Add BorrowerSector. Use gettext to translate enums. #382
Conversation
… Use gettext to translate enums.
Pull Request Test Coverage Report for Build 10513517000Details
💛 - Coveralls |
Feel free to add more commits |
9ba7eca
to
e5c7c28
Compare
…_() signature to allow language to be overridden in tests. Get tests passing in null and "es" languages.
@yolile There are some error messages for you to translate (Or, we can let them continue to be returned in English, and relax the i18n.yml workflow). You can add your commits to finish #362 (or create a new PR). Note: ERROR_CODES.APPLICATION_LAPSED was added in d15c2d8, but it has no translation in the frontend (as of today). I set it to just "Application lapsed" in English, but feel free to change and run https://credere.readthedocs.io/en/latest/contributing/index.html#update-translations |
…ns. Avoid errors due to test order.
3f4b1dd
to
764c40f
Compare
…dere-backend into 362-translate-enums
I get this error when I run
|
pip install -e . (mentioned earlier under setup) |
I'm not sure why "Not authenticated" is not being translated, not sure if we are mocking JWT somewhere |
We can create a follow-up issue to translate model names, if that's desired. |
#362