Improve error handling. Fix logout endpoint. Handle sign-in and MFA errors.#389

Merged

jpmckinney merged 21 commits intomainfrom user-test

Aug 23, 2024

+369-417

Commits on Aug 23, 2024

test: Tidy command tests
jpmckinney
committed
chore: Use "admin", not "ocp"
jpmckinney
committed
chore: There is no need to raise a 500 error, because FastAPI will do that on its own
jpmckinney
committed
fix: Report 400 (request validation errors) to Sentry. Use 422 instead for expected errors.
jpmckinney
committed
chore: Use (and document) appropriate HTTP status codes
jpmckinney
committed
feat: Don't do bare "except Exception" and don't report unexpected and unknown errors to the user
jpmckinney
committed
feat: Improve error messages for integrity errors
jpmckinney
committed
i18n: Regenerate PO file. Correct one typo.
jpmckinney
committed
feat: Add general error handler, to return JSON response for unexpected errors (follow-up a80caaa)
jpmckinney
committed
test: Fix test_update_user
jpmckinney
committed
fix: Fix logout endpoint
jpmckinney
committed
chore: Remove unused loggers
jpmckinney
committed
test: Fix test expectation for new error message
jpmckinney
committed
feat: Log 413 errors to Sentry, to monitor whether 5MB is too small, closes #349
jpmckinney
committed
fix: Prevent user enumeration on login endpoint
jpmckinney
committed
chore: Satisfy mypy. build: Upgrade moto
jpmckinney
committed
fix: Handle EnableSoftwareTokenMFAException and CodeMismatchException errors. Remove ExpiredTemporaryPasswordException. #390
jpmckinney
committed
chore: Fix CI, lint and i18n tests
jpmckinney
committed
Merge branch 'main' into user-test
jpmckinney
committed
i18n: Fix pybabel command to run only against app (like it had with babel.cfg)
jpmckinney
committed
test: Add 1-2 seconds to offsets to avoid timing issues
jpmckinney
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve error handling. Fix logout endpoint. Handle sign-in and MFA errors.#389

Commits on Aug 23, 2024

test: Tidy command tests

chore: Use "admin", not "ocp"

chore: There is no need to raise a 500 error, because FastAPI will do that on its own

fix: Report 400 (request validation errors) to Sentry. Use 422 instead for expected errors.

chore: Use (and document) appropriate HTTP status codes

feat: Don't do bare "except Exception" and don't report unexpected and unknown errors to the user

feat: Improve error messages for integrity errors

i18n: Regenerate PO file. Correct one typo.

feat: Add general error handler, to return JSON response for unexpected errors (follow-up `a80caaa`)

test: Fix test_update_user

fix: Fix logout endpoint

chore: Remove unused loggers

test: Fix test expectation for new error message

feat: Log 413 errors to Sentry, to monitor whether 5MB is too small, closes #349

fix: Prevent user enumeration on login endpoint

chore: Satisfy mypy. build: Upgrade moto

fix: Handle EnableSoftwareTokenMFAException and CodeMismatchException errors. Remove ExpiredTemporaryPasswordException. #390

chore: Fix CI, lint and i18n tests

Merge branch 'main' into user-test

i18n: Fix pybabel command to run only against app (like it had with babel.cfg)

test: Add 1-2 seconds to offsets to avoid timing issues