Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mypy errors and small fixes #394

Merged
merged 7 commits into from
Aug 24, 2024
Merged

Fix Mypy errors and small fixes #394

merged 7 commits into from
Aug 24, 2024

Conversation

jpmckinney
Copy link
Member

@jpmckinney jpmckinney commented Aug 23, 2024

Migration is safe: SELECT * FROM application WHERE award_id IS NULL OR borrower_id IS NULL; has 0 rows.

  • fix: Refresh signing key if Cognito rotated it
  • chore: Fix simple mypy errors in Cognito client usage
  • chore: Split ResetPassword from BasicUser Improve implementation of "multiple models" #376
  • chore: Ignore missing type info that can't be fixed without changing third-party module
  • fix: Make Application.award_id and borrower_id non-nullable
  • chore: Align model with model_id nullability, except Application.lender non-nullable (like .credit_product since b3d05bf)

@coveralls
Copy link

coveralls commented Aug 23, 2024

Pull Request Test Coverage Report for Build 10540159434

Details

  • 21 of 29 (72.41%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 85.984%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/aws.py 0 1 0.0%
app/auth.py 9 11 81.82%
app/routers/users.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
app/aws.py 1 63.64%
app/routers/statistics.py 2 67.57%
Totals Coverage Status
Change from base Build 10540122049: -0.1%
Covered Lines: 1822
Relevant Lines: 2119

💛 - Coveralls

@jpmckinney jpmckinney requested a review from yolile August 23, 2024 20:03
@jpmckinney
Copy link
Member Author

@yolile Merge whenever you're ready. There is a migration (but it should not affect the app).

@yolile yolile merged commit 79b69c1 into main Aug 24, 2024
10 checks passed
@yolile yolile deleted the mypy-auth branch August 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants