Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #443 by reverting a commit in #373 #444

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix #443 by reverting a commit in #373 #444

merged 2 commits into from
Nov 1, 2024

Conversation

jpmckinney
Copy link
Member

@jpmckinney jpmckinney commented Nov 1, 2024 •
edited
Loading

I added a test as well.

@jpmckinney
build: Upgrade pydantic
646f8e4
@jpmckinney
chore: Revert "chore: Use cls.model_validate(payload) instead of cls(…
849fc9c 
…**payload.model_dump()), to avoid 'Expected enum but got str - serialized value may not be as expected'" #443
@jpmckinney jpmckinney requested a review from yolile November 1, 2024 18:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11634565527

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 86.297%
Files with Coverage Reduction New Missed Lines %
app/utils/statistics.py 1 92.73%
Totals Coverage Status
Change from base Build 11633744980: -0.05%
Covered Lines: 1776
Relevant Lines: 2058
💛 - Coveralls

@yolile yolile merged commit 56b5b53 into main Nov 1, 2024
8 checks passed
@yolile yolile deleted the 443-revert-373 branch November 1, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yolile yolile Awaiting requested review from yolile

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpmckinney @coveralls @yolile