moldova: add from_date support

[yolile]

ref #346

[jpmckinney]

I suggest 2018-01-01 (we can even do 2010-01-01), since we don't need to have the exact from date for this API. We should only set a precise from date if the API will error otherwise. That way, if the API fills in historical data, we don't accidentally omit it.

I think the afghanistan spiders are also too precise.

There are some that have a precise month - I don't know if they can be relaxed as well: honduras_portal_bulk, malta, uruguay_base, zambia.

We can update the docstring about setting default_from_date.

[yolile]

Actually, I didn't want to add a default_date for this one, as it is not required, but

kingfisher-collect/kingfisher_scrapy/commands/checkall.py

Line 121 in 81e9a22

self.check_date_spider_argument('from_date', spider_arguments, lambda cls: repr(cls.default_from_date),

fails otherwise.

[jpmckinney]

That check is there, because otherwise how will the f-string be formatted?

[yolile]

The default_from_date is used in:

kingfisher-collect/kingfisher_scrapy/commands/checkall.py

Lines 160 to 165 in 81e9a22

	if self.cls.date_required:
	format_string += " Defaults to {default}."
	elif spider_argument == 'from_date':
	format_string += "\n If ``until_date`` is provided, defaults to {default}."
	elif spider_argument == 'until_date':
	format_string += "\n If ``from_date`` is provided, defaults to {default}."

kingfisher-collect/kingfisher_scrapy/commands/checkall.py

Line 182 in 81e9a22

expected = format_string.format(period=period, format=format_, default=default(self.cls))

but I think that if date_required is false and only from_date or only until_date is implemented, then we don't need a default_from_date or a default_until_date, right?

[jpmckinney]

Yes, it's not required in that specific scenario.

[yolile]

So maybe I can update this check and remove default_from_date from Moldova?

[jpmckinney]

Sounds good, but I think the f-string also needs to be updated as right now it would format it with None, no?

[yolile]

Sounds good, but I think the f-string also needs to be updated as right now it would format it with None, no?

Done, and I also added that the check ask if there is a default_until_date
I also updated all the warnings that we had

I think the afghanistan spiders are also too precise.
There are some that have a precise month - I don't know if they can be relaxed as well: honduras_portal_bulk, malta, uruguay_base, zambia.

Honduras and Uruguay are fine as they have fixed dates that are not going to change. For Afghanistan, zambia and Malta, the spider ask for both dates to be set (from_date and until_date) and I think that is not required, but I will update that as part of #600

[yolile]

@jpmckinney now the coverage is failing because of checkall but I think that is ok

[jpmckinney]

I made some changes. Please have a look and feel free to merge.

[jpmckinney]

@jpmckinney now the coverage is failing because of checkall but I think that is ok

That's fine, it is not a required check.