-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
record_package_schema: fix record definition letter case #1241
Conversation
Signed-off-by: Yohanna Lisnichuk <[email protected]>
hmm now the test is failing due to:
This is because linked releases. Should I move linked releases to record package schema definition as well? |
In Otherwise, for the lint error, we can either copy the exception that was there for |
Signed-off-by: Yohanna Lisnichuk <[email protected]>
I will move the linked release object to a definition in the record_package_schema |
Signed-off-by: Yohanna Lisnichuk <[email protected]>
Signed-off-by: Yohanna Lisnichuk <[email protected]>
Signed-off-by: Yohanna Lisnichuk <[email protected]>
Signed-off-by: Yohanna Lisnichuk <[email protected]>
Signed-off-by: Yohanna Lisnichuk <[email protected]>
Signed-off-by: Yohanna Lisnichuk <[email protected]>
- Sync `releases` description with `Record` description. - Move normative statement to `releases` field. - Prefer "related" to "relating" in description.
@yolile I added a commit, because we try to avoid referencing the JSON type in field descriptions. While fixing that for |
@jpmckinney looks good! should we include the descriptions updates in the changelog as well? |
Good catch! I added a commit. |
@jpmckinney perfect, in that case, do you want to approve this or should I merge it directly? |
closes #641