Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record_package_schema: fix record definition letter case #1241

Merged
merged 10 commits into from
Mar 15, 2021

Conversation

yolile
Copy link
Member

@yolile yolile commented Mar 8, 2021

closes #641

@yolile
Copy link
Member Author

yolile commented Mar 8, 2021

hmm now the test is failing due to:

schema/record-package-schema.json includes "object" in "items/type" at /definitions/Record/properties/releases/oneOf/0/items

This is because linked releases. Should I move linked releases to record package schema definition as well?

@jpmckinney
Copy link
Member

In records_reference there's :pointer: /definitions/record/properties/releases/oneOf/0/items which needs to be updated.

Otherwise, for the lint error, we can either copy the exception that was there for record, or we can moved linked release to a definition to $reference.

@yolile
Copy link
Member Author

yolile commented Mar 11, 2021

or we can moved linked release to a definition to $reference.

I will move the linked release object to a definition in the record_package_schema

@yolile yolile requested a review from jpmckinney March 12, 2021 11:07
- Sync `releases` description with `Record` description.
- Move normative statement to `releases` field.
- Prefer "related" to "relating" in description.
@jpmckinney
Copy link
Member

@yolile I added a commit, because we try to avoid referencing the JSON type in field descriptions. While fixing that for LinkedRelease I noticed a few related descriptions I could tidy.

@yolile
Copy link
Member Author

yolile commented Mar 15, 2021

@jpmckinney looks good! should we include the descriptions updates in the changelog as well?

@jpmckinney
Copy link
Member

Good catch! I added a commit.

@yolile
Copy link
Member Author

yolile commented Mar 15, 2021

@jpmckinney perfect, in that case, do you want to approve this or should I merge it directly?

@yolile yolile merged commit fc28321 into 1.2-dev Mar 15, 2021
@yolile yolile deleted the 641-fix-letter-case-schema-definition branch March 15, 2021 19:02
@jpmckinney jpmckinney added this to the 1.2.0 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants