Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sdg and sdgTarget to classificationScheme codelist #1637

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Sep 11, 2023

closes #1098

Copied from OC4IDS codelist and used https://unstats.un.org/sdgs/indicators/indicators-list/ as the source rather than https://sdgs.un.org/goals

@odscjen odscjen added this to the 1.2.0 milestone Sep 11, 2023
@odscjen odscjen requested a review from jpmckinney September 12, 2023 07:57
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Category is purpose but OCDS doesn't have a purpose field like OC4IDS.

I think it's meant to be item? The other options so far in this codelist are legalBasis and organization.

@odscjen
Copy link
Contributor Author

odscjen commented Sep 21, 2023

Good catch, but I think it should be 'tender' as its the tender that's being classified not any particular items within it. Tender is used as the category in the Tender classification extension

@odscjen odscjen requested a review from jpmckinney September 21, 2023 14:37
@jpmckinney
Copy link
Member

jpmckinney commented Sep 21, 2023

We haven't used 'tender' yet (except in that extension), and many of the 'item' classifications can be used in both 'tender' and 'item' context.

For example, the EU profile uses tender.classification with CPV codes, because the EU doesn't subdivide procedures or lots into individual items.

So, I would use 'item', since presumably individual items can be tagged as SDG-related.

@jpmckinney
Copy link
Member

On second thought, if we only expect a procedure to be tagged with SDGs, then we can leave it as 'tender'.

@odscjen odscjen merged commit aaedd93 into 1.2-dev Sep 21, 2023
10 checks passed
@odscjen odscjen deleted the 1098-sdg-classification-scheme branch September 21, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

itemClassificationScheme: Add codes for SDG and SDGTarget
3 participants