-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate package metadata, improve packaging documentation, refactor record package schema #1640
Conversation
duncandewhurst
commented
Oct 8, 2023
•
edited
Loading
edited
- Closes Deprecate most package metadata #1621
- Closes Package metadata: add a reference to publisher object #1551
- Closes Split out the record and record package schemas #716
Regarding the test failures:
This will be resolved once 1__2__0 is released, I'm not sure what to do about it in the meantime. As a result, the record package schema browser does not display.
I think the tests need to be updated to add exceptions for the new record schema since these warnings were not previously reported when the |
Hmm, Edit: I made some changes. The other errors shouldn't occur again (hard to test the 404 fix locally). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just a few fixes.
Need to delete the two changelog entries for #1422. Also missing changelog entries for:
- Deprecations (the deprecated fields and any sub-fields are no longer required)
- records and releases are no longer required to be unique
Governance-wise, we can't justify the present with the future, so I changed the deprecation notices.
Please make identical or corresponding changes to the release package schema and page.
Co-authored-by: James McKinney <[email protected]>
Done in 80d245b
The 404 error still occurs
Done in 710ab21
Done in d4e6897
|
…events set GITHUB_BASE_REF, needed by test_json.py)
Ah, I've removed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duncandewhurst I added a few more commits to cut other content about the deprecated fields. If you agree, you can merge.
Co-authored-by: James McKinney <[email protected]>
The new commits look good! |