Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema/codelists/partyRole.csv: Clarify description of interestedParty #1644

Merged
merged 8 commits into from
Oct 11, 2023
Merged

schema/codelists/partyRole.csv: Clarify description of interestedParty #1644

merged 8 commits into from
Oct 11, 2023

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst marked this pull request as ready for review October 9, 2023 20:20
@duncandewhurst duncandewhurst requested a review from odscjen October 9, 2023 20:20
odscjen
odscjen requested changes Oct 10, 2023
View reviewed changes
schema/codelists/partyRole.csv Outdated Show resolved Hide resolved
@jpmckinney jpmckinney force-pushed the 1522-interestedParty-description branch from 9d13c46 to db9881d Compare October 10, 2023 22:04
jpmckinney
jpmckinney reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added commits to:

  • clarify enquirer (use "period" not "phase")
  • similarly, avoid "phase" except when referring to OCDS implementation phases

schema/codelists/partyRole.csv Outdated Show resolved Hide resolved
@jpmckinney jpmckinney merged commit 9861906 into 1.2-dev Oct 11, 2023
10 checks passed
@jpmckinney jpmckinney deleted the 1522-interestedParty-description branch October 11, 2023 03:45
@jpmckinney jpmckinney added this to the 1.2.0 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odscjen odscjen odscjen requested changes

@jpmckinney jpmckinney Awaiting requested review from jpmckinney

Assignees
No one assigned
Labels
None yet
Projects
OCDS 1.2
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

partyRole codelist: clarify description of interestedParty
3 participants
@duncandewhurst @jpmckinney @odscjen