Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify, align and clarify related processes #1645

Merged
merged 32 commits into from
Dec 14, 2023
Merged

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst changed the title Updated relatedProcess codelist Update relatedProcess codelist Oct 9, 2023
@duncandewhurst duncandewhurst changed the title Update relatedProcess codelist Simplify, align and clarify related processes Oct 9, 2023
@duncandewhurst duncandewhurst marked this pull request as ready for review October 9, 2023 22:04
@duncandewhurst duncandewhurst requested a review from odscjen October 9, 2023 22:04
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
docs/history/changelog.md Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
docs/schema/codelists.md Outdated Show resolved Hide resolved
docs/schema/codelists.md Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

(2) I think the descriptions in the beginning should also more emphasize the two important, popular and possibly less intuitive use cases: connecting planning and contracting processes and connecting different stages of a multi-stage procedure.

Furthermore, the wording of all the texts shold be more aligned.

I updated relatedProcesses and RelatedProcess to match each other and to mention both of these use cases.

The text from https://standard.open-contracting.org/staging/1.2-dev/en/schema/codelists/#related-process now just copies the text for RelatedProcess, as the original text adds no additional information compared to the new text.

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to review the codes in my previous review.

schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
@duncandewhurst
Copy link
Contributor Author

duncandewhurst commented Nov 2, 2023

For some reason, I had deleted the old codes, rather than deprecating them. I've now reinstated the codes and added the deprecation information.

@duncandewhurst
Copy link
Contributor Author

@jpmckinney just checking that you saw the review request on this PR. Thanks!

docs/history/changelog.md Outdated Show resolved Hide resolved
docs/history/changelog.md Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
schema/codelists/relatedProcess.csv Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

See also my comment: #1645 (comment)

@jpmckinney jpmckinney merged commit d63e69b into 1.2-dev Dec 14, 2023
10 checks passed
@jpmckinney jpmckinney deleted the 1520-relatedProcesses branch December 14, 2023 01:58
@jpmckinney jpmckinney added this to the 1.2.0 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Simplify, align and clarify related processes
3 participants