Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/schema/identifiers.md: Explain who can register an OCID prefix #1708

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst commented Oct 23, 2024

Closes #1325

@duncandewhurst duncandewhurst self-assigned this Oct 23, 2024
@duncandewhurst duncandewhurst marked this pull request as ready for review October 23, 2024 21:07
@duncandewhurst
Copy link
Contributor Author

@jpmckinney the lint check is failing on a bunch of ruff errors across various Python files. Should I go through and fix them or do you want to do that in a separate PR?

@jpmckinney
Copy link
Member

I already have them fixed locally. I'll commit when reviewing.

@jpmckinney
Copy link
Member

Btw, you can now pip install pre-commit and run pre-commit install. The Python and requirements checks will then run if those files are changed.

@jpmckinney jpmckinney merged commit b6fbbbc into 1.2-dev Oct 23, 2024
10 checks passed
@jpmckinney jpmckinney deleted the 1325-explain-prefix-registration branch October 23, 2024 21:34
@duncandewhurst
Copy link
Contributor Author

Btw, you can now pip install pre-commit and run pre-commit install. The Python and requirements checks will then run if those files are changed.

Great! So to reproduce the GitHub Actions checks locally, the only things I need to run manually are the tests in the standard repo and test_csv.py, test_json.py and test_readme.py from standard-maintenance-scripts?

@duncandewhurst
Copy link
Contributor Author

@jpmckinney not sure if you were notified of my comment above

@duncandewhurst
Copy link
Contributor Author

@jpmckinney also, the ruff-format hook makes extensive changes to quotation marks in .manage.py (not sure if anything else) when I change that file.

@jpmckinney
Copy link
Member

Ah, yeah, I forgot to run ruff format. We can do that in another PR.

Yes, those are the only tests that are not run automatically by pre-commit.

@duncandewhurst duncandewhurst mentioned this pull request Oct 23, 2024
14 tasks
@jpmckinney jpmckinney added this to the 1.2.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Clarify "globally unique identifiers" example
2 participants