Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:(palm) limited staff cohorts and gradebook access [BB-7962] #596

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix:(palm) limited staff cohorts and gradebook access [BB-7962] #596

merged 1 commit into from
Oct 16, 2023

Conversation

0x29a
Copy link
Member

@0x29a 0x29a commented Oct 15, 2023

Backport of openedx#33491.

@0x29a 0x29a force-pushed the 0x29a/bb7962/fix-limited-staff-access-to-cohorts-and-gradebook-backport branch from dde7efb to 2c19b07 Compare October 16, 2023 10:53
@0x29a @Agrendalath
fix: limited staff cohorts and gradebook access
8e83fa5 
Limited Staff should not have studio read access by design.

However, since many LMS views depend on the `has_course_author_access` check and `course_author_access_required`
decorator, we have to allow write access until the permissions become more granular. For example, there should
be STUDIO_VIEW_COHORTS and STUDIO_EDIT_COHORTS specifically for the cohorts endpoint, which is used to display
"Cohorts" instructor dashboard tab.

(cherry picked from commit febcccc)
@Agrendalath Agrendalath force-pushed the 0x29a/bb7962/fix-limited-staff-access-to-cohorts-and-gradebook-backport branch from 2c19b07 to 8e83fa5 Compare October 16, 2023 20:27
Agrendalath
Agrendalath approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: in the upstream PR
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@Agrendalath Agrendalath merged commit dff3647 into opencraft-release/palm.1 Oct 16, 2023
41 checks passed
@Agrendalath Agrendalath deleted the 0x29a/bb7962/fix-limited-staff-access-to-cohorts-and-gradebook-backport branch October 16, 2023 21:45
@Agrendalath Agrendalath changed the title fix: limited staff cohorts and gradebook access [BB-7962][BACKPORT] fix:(palm) limited staff cohorts and gradebook access [BB-7962] Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agrendalath Agrendalath Agrendalath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x29a @Agrendalath