fix(redwood): prevent redirects to /undefined after saml auth #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecoholic
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
@Agrendalath Thank you for creating the PR. 👍
- I tested this: Setup a redwood instance from the PR branch and verified that SAML authenticated users aren’t redirected to /undefined.
- I read through the code
- I checked for accessibility issues
- Includes documentation
When a user authenticates using SAML, but their accounts aren't linked, they land on the login page with the message to link their accounts. If the `OC_REDIRECT_ON_TPA_UNLINKED_ACCOUNT` value is not set, they are redirected to `/undefined`. This commit checks that the `redirectURL` is a valid non-empty string before performing the redirect. The bug was introduced in 91f8d36, so this can be safely dropped once that temporary commit is removed from our branches. For Redwood, the relevant commit hash is 64f5dea. Internal-ref: https://tasks.opencraft.com/browse/BB-9010 (cherry picked from commit 9ade4ea)
Agrendalath
force-pushed
the
agrendalath/BB-9010-prevent-redirects-to-undefined-after-saml-auth-redwood-cherry-pick
branch
from
f5135a2 to
2d902ee
Compare
Agrendalath
deleted the
agrendalath/BB-9010-prevent-redirects-to-undefined-after-saml-auth-redwood-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks #669 to Redwood.
Internal-ref: https://tasks.opencraft.com/browse/BB-9010