feat(flagd): Support supplying a custom sync provider for in-process flagd #598
+236
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maks Osowski <[email protected]>
Signed-off-by: Maks Osowski <[email protected]>
github-actions
bot
requested review from
bacherfl,
Kavindu-Dodan and
toddbaert
…option Signed-off-by: Maks Osowski <[email protected]>
alan-kut
reviewed
Dec 3, 2024
| @@ -52,6 +54,8 @@ type providerConfiguration struct { | |||
| Selector string | |||
| SocketPath string | |||
| TLSEnabled bool | |||
| CustomSyncProvider sync.ISync | |||
| CustomSyncProviderUri string | |||
There was a problem hiding this comment.
Why do you need the URI as well?
Is it only to be returned from the makeSyncProvider?
It worries me a little bit because the URI here is not used at all. Caller needs to make sure they return a valid URI for the provider. At the same time most (all?) providers have the uri inside. Maybe it's possible to extend the interface to include a GetURI method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
sync.ISyncimplementation of their own that can fetch the flag config in any way they like.Notes
This PR provides the capability in Go that was recently added in Java.