Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design tokens for app/progress indicator #45

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

sergei-maertens
Copy link
Member

Add new, update existing and remove obsolete design tokens related to the progress indicator styling. This includes some bigger changes to the app component as well.

The SDK will include documentation on how to upgrade, but in principle the CSS should be backwards compatible.

@vaszig
Copy link
Contributor

vaszig commented Nov 28, 2023

Waiting in case something needs changes in combination with the PR review of the SDK open-formulieren/open-forms-sdk#603 , otherwise will be approved.

Add new, update existing and remove obsolete design tokens related to the
progress indicator styling. This includes some bigger changes to the app
component as well.
@sergei-maertens sergei-maertens force-pushed the refactor/app-layout-and-progress-indicator branch from a9b6a57 to 81467e1 Compare November 29, 2023 08:02
@vaszig
Copy link
Contributor

vaszig commented Nov 29, 2023

Waiting in case something needs changes in combination with the PR review of the SDK open-formulieren/open-forms-sdk#603 , otherwise will be approved.

SDK's PR is approved so this can be merged now.

@sergei-maertens sergei-maertens merged commit e2f38b9 into main Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants