Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#3993] Add deriveAddress boolean to addressNL component #155

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 27, 2024

Partly fixes open-formulieren/open-forms#3993

  • Add deriveAddress to the addressNL component
  • Install the new version of the types

@vaszig vaszig marked this pull request as draft May 27, 2024 06:47
@vaszig vaszig force-pushed the of-3993/derive-address-for-addressnl-component branch from beb6ceb to b8ccb44 Compare May 30, 2024 06:26
@vaszig vaszig marked this pull request as ready for review May 30, 2024 06:27
@vaszig
Copy link
Contributor Author

vaszig commented May 30, 2024

Requires the new version of types before merging. See open-formulieren/types#48 .

@vaszig vaszig marked this pull request as draft May 30, 2024 09:06
@vaszig vaszig force-pushed the of-3993/derive-address-for-addressnl-component branch from b8ccb44 to dda7e8b Compare May 31, 2024 13:05
@vaszig vaszig marked this pull request as ready for review June 10, 2024 06:52
@vaszig vaszig requested a review from sergei-maertens June 10, 2024 09:58
src/components/builder/derive-address.tsx Outdated Show resolved Hide resolved
src/components/builder/derive-address.tsx Outdated Show resolved Hide resolved
src/components/builder/derive-address.tsx Outdated Show resolved Hide resolved
src/registry/addressNL/edit.tsx Outdated Show resolved Hide resolved
src/registry/addressNL/preview.tsx Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the of-3993/derive-address-for-addressnl-component branch from dda7e8b to 354b317 Compare June 11, 2024 07:27
@vaszig vaszig force-pushed the of-3993/derive-address-for-addressnl-component branch from 354b317 to 0c6e5f7 Compare June 12, 2024 07:48
@vaszig vaszig requested a review from sergei-maertens June 12, 2024 07:52
@sergei-maertens sergei-maertens merged commit ec864b2 into main Jun 12, 2024
13 checks passed
@sergei-maertens sergei-maertens deleted the of-3993/derive-address-for-addressnl-component branch June 12, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location in repeating groups is functional but requires editing the json
2 participants