Refactor the mode toggle into own component #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are 'display' mode toggles in the component preview side panel and the columns preview (desktop vs mobile). The full form preview will also have a toggle mode between 'structure' and 'webform', so instead of copying over the same implementation, this is extracted as its own re-usable component. Added the implementation, type integration and Storybook story + docs.
The preview toggle is re-implemented based on the toggle mode component so that it can be re-used in the preview panel and the content edit form. The component is moved to its own component file to declutter and make it more clear where each component is implemented. The ComponentPreview is cleaned up to make use of the new component, and the same applies for the Content edit form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #175, which needs a similar mode toggle.
The existing duplication is now captured in a single, re-usable component.