Refactor preview to panel preview #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing for the full-form preview, other preview flavours become relevant (structure and webform), which are decoupled from the preview in the sidebar/panel inside the modal. This refactor updates the type definitions and implementation so that
There is no JSX in this file, nor should there be. The tsx extension was a remnant from the fallback component being defined in this file.
sergei-maertens
force-pushed
the
refactor/preview-to-panel-preview
branch
from
584d5c2 to
be03945
Compare
The focus/blur and race conditions in CI lead to flaky tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted some refactors from #175