Adding map interaction config #198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmolen
force-pushed
the
feature/2177-map-interactions
branch
from
0cf728c to
1644d74
Compare
robinmolen
force-pushed
the
feature/2177-map-interactions
branch
from
1644d74 to
e7254fd
Compare
|
Because this feature will be added after 3.0, this PR is moved to draft. This PR is still ready to be reviewed, it just shouldn't be merged just yet |
vaszig
reviewed
Dec 17, 2024
The map component stories do show the configuration, but the choice doesn't have a visual representation. |
robinmolen
force-pushed
the
feature/2177-map-interactions
branch
from
e92bd4d to
56ca3aa
Compare
Both changes are needed for the leaflet-draw and react-leaflet-draw dependencies. leaflet-draw uses images for the different markers, which are included in the css. For this to work with the scss build, .png and .svg files use the dataurl loader https://esbuild.github.io/content-types/#data-url Typescript errors in the react-leaflet-draw dependency caused a typescript validation/error, which shouldn't happen. Using `skipLibCheck` in the tsconfig.json type issues in the node_modules folder are ignored
robinmolen
force-pushed
the
feature/2177-map-interactions
branch
from
56ca3aa to
72b3cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-formulieren/open-forms#2177
This relies on a update to the types repo: open-formulieren/types#62