Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CI #44

Open
sergei-maertens opened this issue May 10, 2023 · 0 comments
Open

Refactor CI #44

sergei-maertens opened this issue May 10, 2023 · 0 comments

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented May 10, 2023 •
edited
Loading

  • Run job steps in separate jobs
  • Store the build assets (package, storybook...) in artifacts
  • Re-use artifacts for publishing (npm, github pages, storybook tests)

Copy the setup from https://github.com/open-formulieren/formio-builder

-> breaking out into separate jobs gives immediate feedback about which aspect failed for a PR without needing to open the job logs (e.g. linting error vs. package build error vs. storybook build error vs. failed interaction tests)

Since the PR for #31 is not merged yet, it should probably be included there.
@sergei-maertens sergei-maertens self-assigned this May 10, 2023
@sergei-maertens sergei-maertens changed the title Optimize CI so we only build storybook once Refactor CI May 10, 2023
@sergei-maertens sergei-maertens removed their assignment May 10, 2023
This was referenced May 10, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sergei-maertens