Feature/#31 ci #42
Merged
Feature/#31 ci #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvandescheur
force-pushed
the
feature/#31-ci
branch
from
0242832 to
5eb8e9b
Compare
sergei-maertens
requested changes
May 10, 2023
We use react-jsx runtime via the typescript config, which means that React does not need to be in scope (typescript injects the necessary imports during compilation).
sergei-maertens
force-pushed
the
feature/#31-ci
branch
from
5eb8e9b to
c4d96af
Compare
Merged the sb.yml and ci.yml workflow so that they can leverage the workflow artifacts in different jobs to avoid double work.
sergei-maertens
force-pushed
the
feature/#31-ci
branch
from
0c92d41 to
a5591e0
Compare
sergei-maertens
force-pushed
the
feature/#31-ci
branch
from
a5591e0 to
a4300f0
Compare
sergei-maertens
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31