This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
✨ [open-formulieren/open-forms#4380] Add paymentId to plugin #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/4380-ogone-payment-id
branch
from
eaece04 to
3abebe4
Compare
stevenbal
force-pushed
the
feature/4380-ogone-payment-id
branch
from
3abebe4 to
76a96d2
Compare
sergei-maertens
suggested changes
Aug 5, 2024
| if submission is None: | ||
| return None | ||
|
|
||
| return list(submission.payments.values_list("provider_payment_id", flat=True)) |
There was a problem hiding this comment.
I think this now includes all the payments, also payments that have failed. We should only include the completed (and there's a second status) payments.
There was a problem hiding this comment.
ah that's right, I added the same filter used by submission.payments.get_completed_public_order_ids
stevenbal
force-pushed
the
feature/4380-ogone-payment-id
branch
from
76a96d2 to
fda42a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1, so that should be merged first
Closes #2 partially
Closes open-formulieren/open-forms#4380 partially
Related PR open-formulieren/open-forms#4583