🎨 [#36] Simplify building link modifiers list

From PR feedback - unused arguments are removed, which allows for a simpler list building implementation.
open-formulieren · Nov 24, 2023 · a3cfe62 · a3cfe62
1 parent 00a22aa
commit a3cfe62
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/components/ProgressIndicator/ProgressIndicatorItem.js b/src/components/ProgressIndicator/ProgressIndicatorItem.js
@@ -7,8 +7,12 @@ import {getBEMClassName} from 'utils';
 
 import CompletionMark from './CompletionMark';
 
-const getLinkModifiers = (isActive, isApplicable, isCompleted) => {
-  return ['inherit', 'hover', isActive ? 'current' : undefined].filter(mod => mod !== undefined);
+const getLinkModifiers = isActive => {
+  const modifiers = ['inherit', 'hover'];
+  if (isActive) {
+    modifiers.push('current');
+  }
+  return modifiers;
 };
 
 /**
@@ -40,7 +44,7 @@ export const ProgressIndicatorItem = ({
         <Link
           to={to}
           placeholder={!canNavigateTo}
-          modifiers={canNavigateTo ? getLinkModifiers(isActive, isApplicable, isCompleted) : []}
+          modifiers={canNavigateTo ? getLinkModifiers(isActive) : []}
           aria-label={label}
         >
           <FormattedMessage