[OF#3383] Refactor phone number validation #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
===========================================
+ Coverage 55.49% 70.83% +15.34%
===========================================
Files 203 209 +6
Lines 3743 4300 +557
Branches 679 1162 +483
===========================================
+ Hits 2077 3046 +969
+ Misses 1475 1219 -256
+ Partials 191 35 -156
☔ View full report in Codecov by Sentry. |
vaszig
force-pushed
the
of-task/3383-phone-number-validation
branch
2 times, most recently
from
cff2ac5 to
37efe33
Compare
…validators to be OR-ed rather than AND-ed
vaszig
force-pushed
the
of-task/3383-phone-number-validation
branch
from
37efe33 to
e6774dc
Compare
SilviaAmAm
reviewed
Sep 27, 2023
src/formio/validators/plugins.js
Outdated
| }; | ||
| if (anyValid) return true; | ||
|
|
||
| return results.join('<br>'); |
There was a problem hiding this comment.
When testing I don't see the new line 🤔
There was a problem hiding this comment.
Discussed with @SilviaAmAm and @sergei-maertens - a separate issue(#558) has been created for this.
sergei-maertens
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-formulieren/open-forms#3383