Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved minTime/maxTime validation to validate namespace #563

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

sergei-maertens
Copy link
Member

Closes open-formulieren/open-forms#3531

Final part in making these component definitions consistent.

Refs: open-formulieren/types#14, open-formulieren/open-forms#3532

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2787793) 70.87% compared to head (a35cca6) 71.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   70.87%   71.28%   +0.40%     
==========================================
  Files         209      209              
  Lines        4306     4308       +2     
  Branches     1164     1166       +2     
==========================================
+ Hits         3052     3071      +19     
+ Misses       1219     1203      -16     
+ Partials       35       34       -1     
Files Coverage Δ
src/jstests/formio/components/fixtures/time.js 100.00% <ø> (ø)
src/formio/validators/MinMaxTimeValidator.js 80.00% <50.00%> (-4.22%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.rst Outdated Show resolved Hide resolved
…ved into validate namespace

Following the changes in the types package and
the backend.
@sergei-maertens sergei-maertens force-pushed the feature/3531-move-time-component-validators branch from 0f43494 to a35cca6 Compare October 11, 2023 12:10
@sergei-maertens sergei-maertens merged commit 156ebad into main Oct 19, 2023
11 of 12 checks passed
@sergei-maertens sergei-maertens deleted the feature/3531-move-time-component-validators branch October 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update minTime/maxTime validators
2 participants