Fix appointments' story #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
- Coverage 71.47% 71.05% -0.42%
==========================================
Files 209 209
Lines 4319 4319
Branches 1175 1175
==========================================
- Hits 3087 3069 -18
- Misses 1199 1217 +18
Partials 33 33 ☔ View full report in Codecov by Sentry. |
The storybook interaction tests are unreliable w/r to human readable formatting of times and localizing them appropriately. Most notably, it's hard to mock the current date in storybook interaction tests, and it's further complicated by chromatic running tests on machines for which we cannot control the TZ information. The test is moved to jest with a fixed/mocked time so that we avoid DST issues in the future, additionally the TZ information is pinned to Europe/Amsterdam in the test script in package.json.
sergei-maertens
force-pushed
the
fix-create-appointments-story
branch
from
a6f4132 to
5e7cae3
Compare
sergei-maertens
pushed a commit
that referenced
this pull request
Oct 30, 2023
The storybook interaction tests are unreliable w/r to human readable formatting of times and localizing them appropriately. Most notably, it's hard to mock the current date in storybook interaction tests, and it's further complicated by chromatic running tests on machines for which we cannot control the TZ information. The test is moved to jest with a fixed/mocked time so that we avoid DST issues in the future, additionally the TZ information is pinned to Europe/Amsterdam in the test script in package.json. Backport-of: #578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.