Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[open-formulieren/open-forms#3611] Make time bounds validation inclusive #596

Merged
merged 4 commits into from
Nov 22, 2023

[open-formulieren/open-forms#3611] Refactor tests to be parametrized

d245e80
Select commit
Loading
Failed to load commit list.
Merged

[open-formulieren/open-forms#3611] Make time bounds validation inclusive #596

[open-formulieren/open-forms#3611] Refactor tests to be parametrized
d245e80
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 21, 2023 in 0s

64.87% (-7.14%) compared to 7aee061

View this Pull Request on Codecov

64.87% (-7.14%) compared to 7aee061

Details

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7aee061) 72.00% compared to head (d245e80) 64.87%.
Report is 4 commits behind head on main.

❗ Current head d245e80 differs from pull request most recent head d18c7ac. Consider uploading reports for the commit d18c7ac to get more accurate results

Files Patch % Lines
src/formio/validators/MinMaxTimeValidator.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   72.00%   64.87%   -7.14%     
==========================================
  Files         213      194      -19     
  Lines        4319     4134     -185     
  Branches     1152     1105      -47     
==========================================
- Hits         3110     2682     -428     
- Misses       1162     1452     +290     
+ Partials       47        0      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.