Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#3612] Min and max date validation #598

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

SilviaAmAm
Copy link
Contributor

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7aee061) 72.00% compared to head (3d0d5ee) 72.40%.

Files Patch % Lines
src/formio/validators/minMaxDateValidator.js 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
+ Coverage   72.00%   72.40%   +0.39%     
==========================================
  Files         213      213              
  Lines        4319     4323       +4     
  Branches     1152     1155       +3     
==========================================
+ Hits         3110     3130      +20     
+ Misses       1162     1148      -14     
+ Partials       47       45       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Nov 21, 2023
@sergei-maertens sergei-maertens merged commit 2fa208b into main Nov 21, 2023
14 of 15 checks passed
@sergei-maertens sergei-maertens deleted the fix/3612-min-and-max-date-validation branch November 21, 2023 13:44
sergei-maertens pushed a commit that referenced this pull request Nov 21, 2023
@sergei-maertens
Copy link
Member

Backport: 6e0436e

Looks like only stable/2.0.x is affected and older versions didn't have this code (cherry pick fails spectacularly :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date validation: Max date is not validated
3 participants