Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#483] add description to selectboxes and radio option #664

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

nikkiysendoorn1
Copy link
Contributor

@nikkiysendoorn1 nikkiysendoorn1 commented Mar 18, 2024

Closes #483

Renamed the branch, see here the previous PR: #658

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (c73fa85) to head (bd3d49b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   69.78%   69.71%   -0.07%     
==========================================
  Files         207      207              
  Lines        4335     4335              
  Branches     1155     1155              
==========================================
- Hits         3025     3022       -3     
- Misses       1310     1313       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikkiysendoorn1
Copy link
Contributor Author

@sergei-maertens there are two files that give a warning for the prettier, but when I look at my local branch I don't get any changes for these files. So I have no idea what the problem

@nikkiysendoorn1 nikkiysendoorn1 marked this pull request as ready for review March 18, 2024 14:37
@nikkiysendoorn1 nikkiysendoorn1 force-pushed the feature/483-description-per-option branch 2 times, most recently from 2b64aef to 3411b9a Compare March 19, 2024 08:24
src/formio/components/Checkbox.scss Outdated Show resolved Hide resolved
src/formio/templates/radio.ejs Outdated Show resolved Hide resolved
@nikkiysendoorn1 nikkiysendoorn1 force-pushed the feature/483-description-per-option branch from 3203e7c to bd3d49b Compare March 19, 2024 10:07
@nikkiysendoorn1 nikkiysendoorn1 merged commit c771da7 into main Mar 19, 2024
14 of 15 checks passed
@nikkiysendoorn1 nikkiysendoorn1 deleted the feature/483-description-per-option branch March 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use description per option in selectboxes and radio components
2 participants