Cosign improvements #729
Merged
Cosign improvements #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
- Coverage 64.36% 64.08% -0.29%
==========================================
Files 299 300 +1
Lines 6126 6161 +35
Branches 1369 1384 +15
==========================================
+ Hits 3943 3948 +5
- Misses 2152 2183 +31
+ Partials 31 30 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
sergei-maertens
force-pushed
the
feature/4320-cosign-improvements
branch
2 times, most recently
from
a596cec to
b1294d0
Compare
9 tasks
sergei-maertens
force-pushed
the
feature/4320-cosign-improvements
branch
from
e927761 to
c1a88d9
Compare
vaszig
approved these changes
Nov 18, 2024
…s if links in emails are not allowed The link in emails are proper deep-links that bring the user directly to the required start page.
… login URL If a code query parameter is present in the route params, use it to pre-populate the code parameter for the ?next param, which redirects to the submission look-up page on the backend. This will allow the backend to shortcut the form by auto-populating it and validating the authentication state, requiring less user input. This page also works without the parameter and follows the 'old' flow. The login screens will be updated accordingly to redirect to this page.
…igning Added extra paragraph/body clarifying the cosign context. On the CosignStart page, this is displayed as is, without extra heading or background color because the regular login options are (by definition) not displayed on this page. On the regular form start page, the extra paragraph is included under the heading. This entire section is only displayed when no links are included in the cosign email.
…end drive the content of the confirmation page more Added example with simulated backend data for the cosign confirmation page.
The <Story of=...> was deprecated earlier, which caused the buttons not to be properly displayed any longer.
The backend will gain the ability to include the cosign link/button, which will be rendered as a primary button. To point out the right call to actions, the 'return to website' link has been made a secondary button/action. Stories have been updated to reflect the default templates in the backend.
sergei-maertens
force-pushed
the
feature/4320-cosign-improvements
branch
from
c1a88d9 to
c0098ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/open-forms#4320 (partially), required for backend PR open-formulieren/open-forms#4808