Cleanup: prepare to switch from CRA to Vite #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be a way to force sass to resolve imports from node_modules, but it is no longer necessary. Vite does not support it, so we can already prepare by getting rid of them and making the toolchain switch slightly easier/smaller.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
===========================================
- Coverage 77.93% 64.49% -13.44%
===========================================
Files 238 299 +61
Lines 4939 6123 +1184
Branches 1348 1305 -43
===========================================
+ Hits 3849 3949 +100
- Misses 1056 2156 +1100
+ Partials 34 18 -16 ☔ View full report in Codecov by Sentry. |
Vite requires the filename to be .jsx if React components are used in them. Not all files have react components in them, but they might in the future, and this way we only have a single rename commit that we can easily ignore from the git blame, keeping commit history properly intact now and in the future.
sergei-maertens
force-pushed
the
chore/prepare-for-vite-switch
branch
from
352d94a to
bd02c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #724
~in sass imports to point to node_modules (it's a relic of the past).jsto.jsxBoth changes are required to be able to use Vite.