🐛 [open-formulieren/open-forms#4827] Do not add initial_data_ref if empty #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
issue/4827-remove-initial-data-reference-if-not-specified
branch
from
40678e2 to
aabc2ee
Compare
…mpty previously, initial_data_reference=null was added to the login URL next parameters, even in cases when no initial_data_reference was specified
stevenbal
force-pushed
the
issue/4827-remove-initial-data-reference-if-not-specified
branch
from
aabc2ee to
4db5ead
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
+ Coverage 64.16% 64.38% +0.21%
==========================================
Files 299 299
Lines 6123 6126 +3
Branches 1379 1382 +3
==========================================
+ Hits 3929 3944 +15
+ Misses 2164 2151 -13
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
sergei-maertens
approved these changes
Nov 18, 2024
sergei-maertens
deleted the
issue/4827-remove-initial-data-reference-if-not-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, initial_data_reference=null was added to the login URL next parameters, even in cases when no initial_data_reference was specified
closes open-formulieren/open-forms#4827