Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [#429] Rewrite all React tests to testing-library #743

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Nov 27, 2024

Closes #429
Closes #400

I think we're okay at the moment with which tests are unit test-like and which tests are interaction tests.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (2ef0fc3) to head (5d292de).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   79.56%   79.78%   +0.22%     
==========================================
  Files         237      237              
  Lines        4962     4962              
  Branches     1358     1358              
==========================================
+ Hits         3948     3959      +11     
+ Misses        983      972      -11     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robinmolen robinmolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good 👍

@robinmolen robinmolen merged commit f30a93b into main Nov 28, 2024
15 checks passed
@robinmolen robinmolen deleted the chore/429-improve-tests branch November 28, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants