Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content of cosign done page #748

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Dec 5, 2024

Open Forms 3.0 will expose whether confirmation emails are sent
or not in the detail endpoint.
…text

Texts taken from the provided document with desired content. Opted to
not make this configurable yet until we start working on CoSign v3.
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (e57ff26) to head (96d104d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   79.56%   79.21%   -0.36%     
==========================================
  Files         237      237              
  Lines        4962     4964       +2     
  Branches     1358     1358              
==========================================
- Hits         3948     3932      -16     
- Misses        983     1002      +19     
+ Partials       31       30       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit 06c9bc4 into main Dec 6, 2024
12 of 15 checks passed
@sergei-maertens sergei-maertens deleted the feature/4320-cosign-improvements-3 branch December 6, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various co-sign improvements
2 participants