Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#4321] Make form unvailable when submission limit is reached #749

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 6, 2024

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (81cacca) to head (e418141).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Errors/ErrorBoundary.jsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   79.22%   79.45%   +0.22%     
==========================================
  Files         238      239       +1     
  Lines        4973     4979       +6     
  Branches     1347     1358      +11     
==========================================
+ Hits         3940     3956      +16     
+ Misses       1004      993      -11     
- Partials       29       30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some stories too!

@vaszig vaszig force-pushed the of-4321/allow-max-number-of-submissions-per-form branch from fbedf38 to cb689fa Compare December 9, 2024 10:32
@vaszig vaszig force-pushed the of-4321/allow-max-number-of-submissions-per-form branch from cb689fa to e418141 Compare December 10, 2024 07:31
@sergei-maertens sergei-maertens merged commit c28288f into main Dec 13, 2024
14 of 15 checks passed
@sergei-maertens sergei-maertens deleted the of-4321/allow-max-number-of-submissions-per-form branch December 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Als formulier editor wil ik een maximum aantal inzendingen toestaan.
2 participants