-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor backend styles / markup to use more NL DS components #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
refactor/3178-page-styles-to-nlds
branch
from
November 3, 2023 08:59
ebb4d4b
to
59c420e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3575 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 680 680
Lines 21888 21890 +2
Branches 2532 2532
=======================================
+ Hits 21006 21008 +2
Misses 611 611
Partials 271 271
☔ View full report in Codecov by Sentry. |
* The header is now a 'global' include, the ui 'app' is being removed * The main content container now gets styling from the utrecht-page design tokens * Header and footer are to be replaced after the 'view' component is refactored out of the codebase.
They have been replaced with the NL DS utrecht-page component. Design token mapping will take place and/or we will set up some compatibility shims.
Couldn't find any table class names being set anywhere
…tory Moving stuff out of the ui 'app' and simplifying the renderen HTML for better discoverability.
The NL DS component provides in paddings around the content, so our layout component in the backend is obsolete. There is still a layout component in the SDK for the time being, and the paddings of that one need tweaking so that the A11Y toolbar and the form content properly align again.
sergei-maertens
force-pushed
the
refactor/3178-page-styles-to-nlds
branch
from
November 9, 2023 13:07
5c271f7
to
171f24a
Compare
SilviaAmAm
approved these changes
Nov 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3178
Depends on open-formulieren/design-tokens#42
Depends on open-formulieren/open-forms-sdk#592
How to test:
Quite an extensive refactor with lots of things removed.
utrecht-page
andutrecht-page-content
utrecht-page-header
utrecht-page-footer
openforms-layout
Due to some CSS cleanup the width on desktop has now gone from 1170px to 1200px - this is deliberate-ish to simplify the code and should not cause problems, but design tokens can of course be tweaked.
The changes should be backwards compatible - they're definitely intended to be, if you spot issues -> please report them.
TODO: