Merge pull request #58 from open-formulieren/issue/4772-select-compon…

…ent-datatype-string 🐛 [open-formulieren/open-forms#4772] Set select dataType to string
open-formulieren · Nov 12, 2024 · 6af97da · 6af97da
2 parents 4bd994b + a638bf3
commit 6af97da
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/formio/components/select.ts b/src/formio/components/select.ts
@@ -26,6 +26,10 @@ interface BaseSelectSchema {
   // dynamic values into data.values already.
   // So our openForms.dataSrc == itemsExpression results in dataSrc == values.
   dataSrc: 'values';
+  // Fix for https://github.com/open-formulieren/open-forms/issues/4772
+  // ensure the datatype is set to string to avoid formio casting it to other
+  // types (such as integer)
+  dataType: 'string';
 }
 
 /**

diff --git a/test-d/formio/components/select.test-d.ts b/test-d/formio/components/select.test-d.ts
@@ -7,6 +7,7 @@ expectAssignable<SelectComponentSchema>({
   id: 'yejak',
   type: 'select',
   dataSrc: 'values',
+  dataType: 'string',
   key: 'someSelect',
   label: 'Some select',
   openForms: {
@@ -28,6 +29,7 @@ expectAssignable<SelectComponentSchema>({
   id: 'yejak',
   type: 'select',
   dataSrc: 'values',
+  dataType: 'string',
   key: 'someSelect',
   label: 'Some select',
   openForms: {
@@ -42,6 +44,7 @@ expectAssignable<SelectComponentSchema>({
   id: 'yejak',
   type: 'select',
   dataSrc: 'values',
+  dataType: 'string',
   key: 'someSelect',
   label: 'Some select',
   multiple: false,
@@ -58,6 +61,7 @@ expectAssignable<SelectComponentSchema>({
   id: 'yejak',
   type: 'select',
   dataSrc: 'values',
+  dataType: 'string',
   key: 'someSelect',
   label: 'Some select',
   multiple: true,
@@ -74,6 +78,7 @@ expectAssignable<SelectComponentSchema>({
   id: 'yejak',
   type: 'select',
   dataSrc: 'values',
+  dataType: 'string',
   key: 'someSelect',
   label: 'Some select',
   multiple: true,
@@ -90,6 +95,7 @@ expectAssignable<SelectComponentSchema>({
   id: 'yejak',
   type: 'select',
   dataSrc: 'values',
+  dataType: 'string',
   key: 'someSelect',
   label: 'Some select',
   defaultValue: 'dummy',
@@ -122,6 +128,7 @@ expectAssignable<SelectComponentSchema>({
   id: 'yejak',
   type: 'select',
   dataSrc: 'values',
+  dataType: 'string',
   // basic tab
   label: 'Some select',
   key: 'someSelect',