Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add missing properties for file component #19

Merged
merged 1 commit into from
Oct 27, 2023
Merged

🐛 Add missing properties for file component #19

merged 1 commit into from
Oct 27, 2023

Conversation

sergei-maertens
Copy link
Member

  • webcam: false is set in our default form builder configuration, and it affects the SDK/renderer in that no webcam integration needs to be built/enabled
  • options object is set as string in our current builder, but it is then at run-time parsed as JSON. We can shortcut this and directly set it as an object. The withCredentials option is required for XHR uploads to send cookies. This will likely become obsolete when we replace the formio renderer with our own and have a fetch-based upload client.

@sergei-maertens
🐛 Add missing properties for file component
6853fe2 
* webcam: false is set in our default form builder configuration, and it
  affects the SDK/renderer in that no webcam integration needs to be
  built/enabled
* options object is set as string in our current builder, but it is
  then at run-time parsed as JSON. We can shortcut this and directly
  set it as an object. The withCredentials option is required for
  XHR uploads to send cookies. This will likely become obsolete
  when we replace the formio renderer with our own and have a
  fetch-based upload client.
Viicos
Viicos approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options object is set as string in our current builder, but it is then at run-time parsed as JSON

Just a general question, what does it mean exactly at run-time in this context? Is it the OF backend run-time?

@sergei-maertens
Copy link
Member Author

options object is set as string in our current builder, but it is then at run-time parsed as JSON

Just a general question, what does it mean exactly at run-time in this context? Is it the OF backend run-time?

nope, in the SDK/Formio renderer: https://github.com/formio/formio.js/blob/4.13.x/src/providers/storage/url.js#L72

@sergei-maertens sergei-maertens merged commit 528656b into main Oct 27, 2023
6 checks passed
@sergei-maertens sergei-maertens deleted the fix/missing-file-properties branch October 30, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergei-maertens @Viicos