docs(changeset): account for button post_url in frameInfo

open-frames · May 2, 2024 · f9e2098 · f9e2098
1 parent 7d291dd
commit f9e2098
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/.changeset/tricky-eyes-trade.md b/.changeset/tricky-eyes-trade.md
@@ -0,0 +1,5 @@
+---
+"@open-frames/proxy": patch
+---
+
+account for button post_url in frameInfo
diff --git a/packages/server/src/parser.test.ts b/packages/server/src/parser.test.ts
@@ -188,8 +188,7 @@ const testCases = [
 			'of:button:1:target': EXPECTED_FRAME_POST_URL,
 			'of:button:1:post_url': EXPECTED_FRAME_TX_POST_URL,
 		},
-		frameInfo: {
-			ogImage: EXPECTED_FRAME_IMAGE,
+		expectedFrameInfo: {
 			acceptedClients: {
 				xmtp: EXPECTED_FRAME_XMTP_VERSION,
 				lens: '2',
@@ -200,7 +199,6 @@ const testCases = [
 				alt: EXPECTED_IMAGE_ALT,
 			},
 			postUrl: EXPECTED_FRAME_POST_URL,
-			state: EXPECTED_FRAME_STATE,
 			buttons: {
 				'1': {
 					action: 'tx',

diff --git a/packages/server/src/parser.ts b/packages/server/src/parser.ts
@@ -112,13 +112,18 @@ function updateFrameButton(frameInfo: DeepPartial<OpenFrameResult>, key: string,
 	frameInfo.buttons = frameInfo.buttons || {};
 	const button = frameInfo.buttons[buttonIndex] || {};
 	if (maybeField) {
-		const field = maybeField as keyof OpenFrameButton;
+		const field = maybeField as keyof OpenFrameButton | 'post_url';
 		if (field === 'action' && isAllowedAction(value)) {
 			button.action = value;
 		}
 		if (field === 'target') {
 			button.target = value;
 		}
+		if (button.action === 'tx') {
+			if (field === 'post_url') {
+				button.post_url = value;
+			}
+		}
 	} else {
 		button.label = value;
 	}