Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noe/add meta tag max size #23

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

nmalzieu
Copy link
Contributor

@nmalzieu nmalzieu commented Mar 28, 2024

Now that the proxy server handles a meta tag max size parameter, add it to the proxy client

@neekolas
Copy link
Collaborator

Looks good to me. Think you'll need to rebase or merge against main to get the true diff, since I see duplicate commits.

@nmalzieu nmalzieu force-pushed the noe/add-meta-tag-max-size branch from d4bb53a to de5e422 Compare March 28, 2024 14:12
@nmalzieu
Copy link
Contributor Author

Looks good to me. Think you'll need to rebase or merge against main to get the true diff, since I see duplicate commits.

sorry about that! should be fixed now.

neekolas
neekolas previously approved these changes Mar 28, 2024
alexrisch
alexrisch previously approved these changes Mar 28, 2024
@neekolas
Copy link
Collaborator

You'll also want to run yarn changeset so that this publishes a new version of the library

@nmalzieu nmalzieu dismissed stale reviews from alexrisch and neekolas via b38ef04 March 28, 2024 23:33
@nmalzieu
Copy link
Contributor Author

@neekolas done

@neekolas neekolas merged commit accf440 into open-frames:main Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants