-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add model_info_local
argument to download
function
#49
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution. But why we need download a checkpoint from remote GitHub. |
@zhouzaida because model_zoo.yml file may not be available at local. |
got it |
Got it. Please add an unittest. Another thing is that the config file can not be successfully obtained from remote because the config is parsed from the local repo. |
@zhouzaida it is also an issue. wheel package of |
add tests for `model_info_local` argument in download
@zhouzaida added tests for |
hi @fcakyon , the following lines should be moved. In addition, we download checkpoints and configs by default so we can provide two options to only download one of them Lines 63 to 71 in eb35cce
|
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage ? 63.81%
=======================================
Files ? 21
Lines ? 1564
Branches ? 347
=======================================
Hits ? 998
Misses ? 431
Partials ? 135
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Motivation
We want to parse model info from remote when using download function. Fixes #51
Modification
add
model_info_local
argument todownload
function.BC-breaking (Optional)
Previous usage is not affected.