Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMSIG] Support StableSR Algorithm Reproduction #1941

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

aptsunny
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 8.27% and project coverage change: -3.13% ⚠️

Comparison is base (9d37453) 82.59% compared to head (b418b35) 79.46%.
Report is 17 commits behind head on main.

❗ Current head b418b35 differs from pull request most recent head c69296b. Consider uploading reports for the commit c69296b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
- Coverage   82.59%   79.46%   -3.13%     
==========================================
  Files         413      420       +7     
  Lines       27812    28970    +1158     
  Branches     4366     4508     +142     
==========================================
+ Hits        22970    23020      +50     
- Misses       3893     5001    +1108     
  Partials      949      949              
Flag Coverage Δ
unittests 79.46% <8.27%> (-3.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mmagic/models/archs/autoencoder.py 0.00% <0.00%> (ø)
mmagic/models/archs/diffjpeg.py 0.00% <0.00%> (ø)
mmagic/models/archs/diffusionmodules.py 0.00% <0.00%> (ø)
mmagic/models/archs/distributions.py 0.00% <0.00%> (ø)
mmagic/models/editors/dreambooth/dreambooth.py 62.23% <ø> (ø)
mmagic/models/editors/stylegan1/stylegan_utils.py 100.00% <ø> (ø)
...els/editors/textual_inversion/textual_inversion.py 19.81% <19.81%> (ø)
mmagic/datasets/textual_inversion_dataset.py 40.62% <40.62%> (ø)
mmagic/datasets/__init__.py 100.00% <100.00%> (ø)
mmagic/models/editors/__init__.py 100.00% <100.00%> (ø)
... and 21 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zengyh1900 zengyh1900 self-requested a review August 24, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants