Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix a bug in e2e_hmean_iou_metric.py for in-place filtering bug #1999

Open
wants to merge 1 commit into
base: dev-1.x
Choose a base branch
from

Conversation

ChuanyangGong
Copy link

Motivation

This PR aims to fix a bug in the ABCNet project. The bug occurs when performing in-place filtering on predicted texts, causing subsequent filtering operations to fail.

Modification

The bug is fixed by creating a new list filtered_pred_texts to store the filtered prediction texts, ensuring that the original pred_texts list is not modified in-place.

BC-breaking (Optional)

N/A

Use cases (Optional)

N/A

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants