Skip to content

Commit

Permalink
Update python version (#285)
Browse files Browse the repository at this point in the history
  • Loading branch information
hughesjj authored Mar 6, 2024
1 parent c21047b commit 29a0e97
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
2 changes: 2 additions & 0 deletions semantic-conventions/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Please update the changelog as part of any significant pull request.

## Unreleased

- Change minimum support python version to 3.10 in setup.cfg and Dockerfile
([#285](https://github.com/open-telemetry/build-tools/pull/285))
- BREAKING: Make stability required (also: fix ref and extends, render badges on metrics).
([#272](https://github.com/open-telemetry/build-tools/pull/272))
- BREAKING: Make stability and deprecation independent properties.
Expand Down
3 changes: 2 additions & 1 deletion semantic-conventions/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,11 @@ _Note:_ `venv` integrations exist for IDEs such as [PyCharm](https://www.jetbrai

See the offical documents for creating and [using](https://docs.python.org/3/tutorial/venv.html) a [venv environment](https://docs.python.org/3/library/venv.html). All "python" commands listed in this document should be run in an activated `venv`.

**Note**, ensure the venv you create is using the earliest supported version of python as defined in `setup.cfg`

```bash
# note that it's convention to not store your venv in your working directory, lest build tooling "pick up" venv configuration.
python3 -m venv ../semconvgen
python3.10 -m venv ../semconvgen
source ../semconvgen/bin/activate
# Run your pip/wheel commands as described elsewhere in this documentation here.
# reset your environment by typing 'deactivate' or by exiting your TTY
Expand Down
2 changes: 1 addition & 1 deletion semantic-conventions/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.9.5-alpine3.12
FROM python:3.10-alpine
LABEL maintainer="The OpenTelemetry Authors"
ADD *.whl /semconvgen/
WORKDIR /semconvgen
Expand Down
11 changes: 6 additions & 5 deletions semantic-conventions/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,13 @@ classifiers =
License :: OSI Approved :: Apache Software License
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.6
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Programming Language :: Python :: 3.13
[options]
python_requires = >=3.6
# Ensure this remains synced with our Dockerfile
python_requires = >=3.10
package_dir=
=src
packages=find_namespace:
Expand Down

0 comments on commit 29a0e97

Please sign in to comment.