[processor/transform] Move config structure to TQL #13373
Conversation
TylerHelmuth
added
the
Skip Changelog
|
/cc @kentquirk |
| } | ||
|
|
||
| // SignalConfig configures TQL queries to execute. | ||
| type SignalConfig struct { |
There was a problem hiding this comment.
Do we ever want to have a different config between signals?
There was a problem hiding this comment.
The current config allows configuring different queries per signal, but thats it so far. Haven't come across a use-case yet for the config beside defining the queries themselves.
There was a problem hiding this comment.
Are you thinking instead of a SignalConfig we'd have TracesConfig, MetricsConfig, and LogsConfig? At the moment all 3 would need the Queries property and would be duplicates of one another. Have anything in mind that we'd add to one but not the other?
There was a problem hiding this comment.
Should we consider having each of Traces, Metrics, and Logs be an interface instead of a struct? That would be something like:
type Queryer interface {
GetQueries() []string
}Or does that screw up something relating to loading the configurations?
There was a problem hiding this comment.
I believe they need to be structs to interact correctly with component.ProcessorFactory
|
@kentquirk @bogdandrutu please review. |
| } | ||
|
|
||
| // SignalConfig configures TQL queries to execute. | ||
| type SignalConfig struct { |
There was a problem hiding this comment.
Should we consider having each of Traces, Metrics, and Logs be an interface instead of a struct? That would be something like:
type Queryer interface {
GetQueries() []string
}Or does that screw up something relating to loading the configurations?
TylerHelmuth
added
the
ready to merge
Description:
Moves the basic SQL-like config to config to the TQL. This will allow users of the TQL to use the SQL-like config.
This is a building-block to providing a declarative-like configuration.
Link to tracking Issue:
Works towards #11852
Testing:
Updated unit tests