[pkg/ottl] Allow Converter in constant BoolExpr #20911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu,
evan-bradley,
jpkrohling and
kovrus
as code owners
github-actions
bot
added
connector/count
internal/filter
pkg/ottl
processor/filter
TylerHelmuth
force-pushed
the
ottl-allow-converters-as-constbool
branch
from
ea735a7 to
c310af5
Compare
TylerHelmuth
force-pushed
the
ottl-allow-converters-as-constbool
branch
from
c310af5 to
1d7e2f9
Compare
Co-authored-by: Evan Bradley <[email protected]>
TylerHelmuth
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the OTTL grammar to allow Converters in constant BoolExpr. This means that instead of writing
... where IsMatch(attributes["host.name"], ".*localhost.*") == trueyou may (it's your choice, both syntaxes are valid) simply write
... where IsMatch(attributes["host.name"], ".*localhost.*").If the Converter returns a value that is not a bool an error is returned.
The Converter is treated like a literal
trueorfalsein a BooleanExpression and can be ANDed, ORed, grouped, and negated like other BooleanExpressions.Link to tracking Issue:
I finally added this bc I didn't like typing
== truewhile working on #18642.Testing:
Updated unit tests
Documentation:
Updated OTTL documentation and the READMEs of components that were using the inefficient syntax.