Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/jaegerremotesampling] jaegerremotesampling adopts component.UseLocalHostAsDefaultHost feature gate #30983

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 1, 2024

Description:
jaegerremotesampling extension adopts component.UseLocalHostAsDefaultHost feature gate

Link to tracking Issue:
#30702

Fixes #30982

Documentation:
Updated docs.

@atoulme atoulme requested a review from yurishkuro as a code owner February 1, 2024 06:17
@atoulme atoulme requested review from a team and TylerHelmuth February 1, 2024 06:17
@github-actions github-actions bot requested a review from frzifus February 1, 2024 06:17
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 1, 2024
@frzifus
Copy link
Member

frzifus commented Feb 1, 2024

It localhost is becoming the default on the future, why do we change it now to be 0.0.0.0 by default und change it back? :X

@atoulme
Copy link
Contributor Author

atoulme commented Feb 1, 2024

It localhost is becoming the default on the future, why do we change it now to be 0.0.0.0 by default und change it back? :X

the docs are incorrect, by default the extension binds to 0.0.0.0 right now - which is why we are doing this modification.

@mx-psi mx-psi merged commit b60fbd5 into open-telemetry:main Feb 1, 2024
95 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 1, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
…nt.UseLocalHostAsDefaultHost` feature gate (open-telemetry#30983)

Description:
jaegerremotesampling extension adopts
component.UseLocalHostAsDefaultHost feature gate

Link to tracking Issue:

open-telemetry#30702

Fixes
open-telemetry#30982

Documentation:
Updated docs.

Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension/jaegerremotesampling Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use localhost feature gate on extension/jaegerremotesampling
4 participants