[extension/sumologicextension] Replace go-ps with gopsutil #36358
Conversation
go-ps is no longer maintained. Signed-off-by: Eric Chlebek <[email protected]>
|
It's unclear to me whether this change necessitates a changelog entry, I suspect it does not as no exported APIs have changed. Please let me know if I should include one. |
| @@ -711,16 +711,20 @@ var sumoAppProcesses = map[string]string{ | |||
| "kafka-server-start.sh": "kafka", // Need to test this, most common shell wrapper. | |||
| } | |||
|
|
|||
| func filteredProcessList() ([]string, error) { | |||
| func filteredProcessList(ctx context.Context) ([]string, error) { | |||
There was a problem hiding this comment.
is there a reason why context was added here? because what this function basically do is loop through the the map above this ^^
only asking cause i'm working on the extension that have this change included (removing go-ps and using gopsutil) 😆
There was a problem hiding this comment.
It's just to allow context values to be propagated to ExeWithContext, which calls other functions that can make use of those values further down the call stack. At the moment, those values are not being passed, however.
|
Looks like the extension tests have failed. Locally, there were no failures, but I didn't test with any build tags. Will investigate and move this PR to draft status. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
go-ps is no longer maintained.
Link to tracking issue
Fixes SumoLogic/sumologic-otel-collector#1575
However, I'm unaware of an equivalent issue in this repository. I can add one if required.
Testing
Tests pass, I don't think this change introduces much risk.
Context
There was previously another PR that was abandoned: #33403